From: Pavel Emelyanov <xemul@openvz•org>
To: David Miller <davem@davemloft•net>, johannes@sipsolutions•net
Cc: netdev@axxeo•de, linville@tuxdriver•com,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH 1/4][MAC80211]: Fix GFP_KERNEL allocation under read lock.
Date: Wed, 07 May 2008 09:54:53 +0400 [thread overview]
Message-ID: <4821442D.8010801@openvz.org> (raw)
In-Reply-To: <20080506.134047.86330538.davem@davemloft.net>
David Miller wrote:
> From: Pavel Emelyanov <xemul@openvz•org>
> Date: Tue, 06 May 2008 21:46:38 +0400
>
>> I do not quite like doing so. Since this relies on fact that kfree bears
>> NULL pointers. But if we ever switch from kmalloc to kmem_cache_alloc,
>> this will result in an oops.
>
> The whole reason we made kfree allow NULL points is so that
> checks for it would be ommitted at kfree calls sides, whether
> they be direct or indirect.
Hm... I really thought that this check in kfree is just for sanity
against some 3rd part code. But why kmem_cache_free() is not such then?
> Adding the check for some theoretical-or-not future change is
> rediculious.
Well, this makes sense. Shall I resubmit the set?
Thanks,
Pavel
next prev parent reply other threads:[~2008-05-07 5:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 14:46 [PATCH 1/4][MAC80211]: Fix GFP_KERNEL allocation under read lock Pavel Emelyanov
2008-05-06 16:40 ` Ingo Oeser
2008-05-06 17:46 ` Pavel Emelyanov
[not found] ` <4820997E.1070305-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2008-05-06 20:40 ` David Miller
2008-05-07 5:54 ` Pavel Emelyanov [this message]
2008-05-07 5:59 ` David Miller
2008-05-08 18:51 ` John W. Linville
[not found] ` <20080508185123.GA7250-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2008-05-08 18:53 ` John W. Linville
[not found] ` <200805061840.37713.netdev-BkyiQQGWkgE@public.gmane.org>
2008-05-06 21:12 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4821442D.8010801@openvz.org \
--to=xemul@openvz$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@axxeo$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox