From: Patrick McHardy <kaber@trash•net>
To: Vlad Yasevich <vladislav.yasevich@hp•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
linux-sctp@vger•kernel.org,
lksctp-developers@lists•sourceforge.net,
Wei Yongjun <yjwei@cn•fujitsu.com>
Subject: Re: [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk
Date: Tue, 13 May 2008 13:30:49 +0200 [thread overview]
Message-ID: <48297BE9.9020204@trash.net> (raw)
In-Reply-To: <1210360195-16524-2-git-send-email-vladislav.yasevich@hp.com>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Vlad Yasevich wrote:
> @@ -2827,6 +2827,19 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
> union sctp_addr addr;
> union sctp_addr_param *addr_param;
>
> + switch (addr_param->v4.param_hdr.type) {
^^^ use of addr_param
> + case SCTP_PARAM_IPV6_ADDRESS:
> + if (!asoc->peer.ipv6_address)
> + return SCTP_ERROR_INV_PARAM;
> + break;
> + case SCTP_PARAM_IPV4_ADDRESS:
> + if (!asoc->peer.ipv4_address)
> + return SCTP_ERROR_INV_PARAM;
> + break;
> + default:
> + return SCTP_ERROR_INV_PARAM;
> + }
> +
> addr_param = (union sctp_addr_param *)
> ((void *)asconf_param + sizeof(sctp_addip_param_t));
^^^ initialization of addr_param
The patch is wrong and needs this fix on top.
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1465 bytes --]
commit 1beb4530b5bf180d8989993d3050fabdf21522cc
Author: Patrick McHardy <kaber@trash•net>
Date: Tue May 13 13:27:22 2008 +0200
[SCTP]: Fix use of uninitialized pointer
Introduced by c4492586 (sctp: Add address type check while process
paramaters of ASCONF chunk):
net/sctp/sm_make_chunk.c: In function 'sctp_process_asconf':
net/sctp/sm_make_chunk.c:2828: warning: 'addr_param' may be used uninitialized in this function
net/sctp/sm_make_chunk.c:2828: note: 'addr_param' was declared here
Signed-off-by: Patrick McHardy <kaber@trash•net>
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 6eeee53..bbc7107 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -2827,6 +2827,9 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
union sctp_addr addr;
union sctp_addr_param *addr_param;
+ addr_param = (union sctp_addr_param *)
+ ((void *)asconf_param + sizeof(sctp_addip_param_t));
+
switch (addr_param->v4.param_hdr.type) {
case SCTP_PARAM_IPV6_ADDRESS:
if (!asoc->peer.ipv6_address)
@@ -2840,9 +2843,6 @@ static __be16 sctp_process_asconf_param(struct sctp_association *asoc,
return SCTP_ERROR_INV_PARAM;
}
- addr_param = (union sctp_addr_param *)
- ((void *)asconf_param + sizeof(sctp_addip_param_t));
-
af = sctp_get_af_specific(param_type2af(addr_param->v4.param_hdr.type));
if (unlikely(!af))
return SCTP_ERROR_INV_PARAM;
next prev parent reply other threads:[~2008-05-13 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 19:09 [PATCH] [SCTP]: Do not enable peer IPv6 address support on PF_INET socket Vlad Yasevich
2008-05-09 19:09 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk Vlad Yasevich
2008-05-09 22:12 ` David Miller
2008-05-13 11:30 ` Patrick McHardy [this message]
2008-05-13 12:48 ` Vlad Yasevich
2008-05-13 22:32 ` David Miller
2008-05-14 0:56 ` Wei Yongjun
2008-05-14 1:14 ` David Miller
2008-05-14 1:49 ` Wei Yongjun
2008-05-14 6:25 ` David Miller
2008-05-09 22:11 ` [PATCH] [SCTP]: Do not enable peer IPv6 address support on PF_INET socket David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48297BE9.9020204@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=lksctp-developers@lists$(echo .)sourceforge.net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vladislav.yasevich@hp$(echo .)com \
--cc=yjwei@cn$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox