From: Jeff Garzik <jeff@garzik•org>
To: Andi Kleen <andi@firstfloor•org>
Cc: Subbu Seetharaman <subbus@serverengines•com>, netdev@vger•kernel.org
Subject: Re: [PATCH 9/15] BE NIC driver - Linux system abstraction files
Date: Thu, 15 May 2008 13:33:28 -0400 [thread overview]
Message-ID: <482C73E8.6090208@garzik.org> (raw)
In-Reply-To: <87mymrztse.fsf@basil.nowhere.org>
Andi Kleen wrote:
> "Subbu Seetharaman" <subbus@serverengines•com> writes:
>> + */
>> +/*
>> + * system abstraction functions / macros for Linux
>
> Sorry, pretty much this complete file has to go and the callers
> be fixed to use the native Linux functions directly. Some of it
> was even wrong, like it's not legal to cast atomic_t like you did.
>
> Also a lot of facilities you reimplement here exist already in Linux
> anyways under other names.
Quite agreed (speaking as net driver maintainer)
Jeff
next prev parent reply other threads:[~2008-05-15 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 9:26 [PATCH 9/15] BE NIC driver - Linux system abstraction files Subbu Seetharaman
2008-05-15 11:33 ` Andi Kleen
2008-05-15 17:33 ` Jeff Garzik [this message]
[not found] ` <20080515173841.A0A48189004A@one.firstfloor.org>
2008-05-15 17:49 ` Andi Kleen
2008-05-15 20:22 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482C73E8.6090208@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=andi@firstfloor$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=subbus@serverengines$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox