From: Patrick McHardy <kaber@trash•net>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel•com>
Cc: Ichiro Suzuki <isuzuki@miraclelinux•com>,
netdev@vger•kernel.org, Naohiro Ooiwa <nooiwa@miraclelinux•com>
Subject: Re: Question about VLAN + checksum offloading
Date: Mon, 19 May 2008 19:45:24 +0200 [thread overview]
Message-ID: <4831BCB4.9070704@trash.net> (raw)
In-Reply-To: <4831BC4D.7000601@trash.net>
Patrick McHardy wrote:
> Waskiewicz Jr, Peter P wrote:
>>> o If so, is there any mechanism to propagate real_dev->features
>>> flags in vlan.c?
>>
>> There isn't an explicit way. I had written patches into e1000, igb,
>> e1000e, and ixgbe to propogate the VLAN flags within the driver when the
>> VLAN device was created. The trick though is if you remove a feature
>> flag with ethtool, say checksum offload, on your main device, you
>> probably should turn it off on your VLAN devices. Patrick McHardy
>> pointed me at netdev_feature_change() to use within the driver. I'll
>> admit I haven't had the time to fix my drivers to use this call, but it
>> certainly looks like the way to go. Please see the (middle) of the
>> thread here: http://marc.info/?l=linux-netdev&m=120878809806631&w=2
>>
>>> o If such mechanism doesn't exist, is my patch reasonable?
>>
>> I would say yes, halfway. The issue is you probably want to remove the
>> feature flag from the VLAN device if you removed the flag from the
>> parent device as well.
>
>
> Yes, it should use the same mechanism as suggested for the
> VLAN accel feature. And it should be limited to features
I meant TSO, sorry.
> that are known to work, not just blindly copy everything.
>
> I will be catching up with the VLAN patches posted recently
> sometime next week. I guess I can then also add a patch for
> feature propagation myself if you don't beat me to it :)
next prev parent reply other threads:[~2008-05-19 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 7:52 Question about VLAN + checksum offloading Ichiro Suzuki
2008-05-19 17:36 ` Waskiewicz Jr, Peter P
2008-05-19 17:43 ` Patrick McHardy
2008-05-19 17:45 ` Patrick McHardy [this message]
2008-05-20 3:19 ` Ichiro Suzuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831BCB4.9070704@trash.net \
--to=kaber@trash$(echo .)net \
--cc=isuzuki@miraclelinux$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nooiwa@miraclelinux$(echo .)com \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox