Subject: Re: FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

From: Brice Goglin <[email-masked]>
Date: Thu, 22 May 2008 09:02:19 +0200

I don't see this patch applied anywhere, what happened to it?

Brice

Dan Williams wrote:
> Subject: net_dma: Remove duplicate assignment in dma_skb_copy_datagram_iovec
>
> From: Brice Goglin <[email-masked]>
>
> No need to compute copy twice in the frags loop in
> dma_skb_copy_datagram_iovec().
>
> Signed-off-by: Brice Goglin <[email-masked]>
> Acked-by: Shannon Nelson <[email-masked]>
> Signed-off-by: Maciej Sosnowski <[email-masked]>
> Signed-off-by: Dan Williams <[email-masked]>
> ---
> Hi Maciej,
>
> Please be careful about maintaining attribution of the patch.
>
> Regards,
> Dan
>
>  net/core/user_dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/net/core/user_dma.c b/net/core/user_dma.c
> index 0ad1cd5..c77aff9 100644
> --- a/net/core/user_dma.c
> +++ b/net/core/user_dma.c
> @@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,
>  
>  		end = start + skb_shinfo(skb)->frags[i].size;
>  		copy = end - offset;
> -		if ((copy = end - offset) > 0) {
> +		if (copy > 0) {
>  			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
>  			struct page *page = frag->page;
>  
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>