From: Jeff Garzik <jgarzik@pobox•com>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: netdev@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Nick Piggin <nickpiggin@yahoo•com.au>,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [PATCH 2/5] sky2: don't warn if page allocation fails
Date: Thu, 22 May 2008 05:57:44 -0400 [thread overview]
Message-ID: <48354398.9070307@pobox.com> (raw)
In-Reply-To: <20080515000432.989061538@vyatta.com>
>
> for (i = 0; i < sky2->rx_nfrags; i++) {
> - struct page *page = alloc_page(GFP_ATOMIC);
> + struct page *page = alloc_page(GFP_ATOMIC | __GFP_NOWARN);
>
> if (!page)
> goto free_partial;
IMO it's inappropriate to add these warnings to net drivers that
properly check all return values.
This approach is too maintenance intensive, and winds up fixing the same
problem over and over again -- a hint that the fix is in the wrong place.
Jeff
next prev parent reply other threads:[~2008-05-22 9:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 0:04 [PATCH 0/5] sky2: driver update Stephen Hemminger
2008-05-15 0:04 ` [PATCH 1/5] sky2: restore vlan acceleration on reset Stephen Hemminger
2008-05-21 17:02 ` Stephen Hemminger
2008-05-21 17:12 ` Jeff Garzik
2008-05-22 10:01 ` Jeff Garzik
2008-05-15 0:04 ` [PATCH 2/5] sky2: don't warn if page allocation fails Stephen Hemminger
2008-05-22 9:57 ` Jeff Garzik [this message]
2008-05-27 18:47 ` Stephen Hemminger
2008-06-03 6:16 ` Nick Piggin
2008-05-15 0:04 ` [PATCH 3/5] sky2: split phy power into two functions Stephen Hemminger
2008-05-31 2:20 ` Jeff Garzik
2008-05-15 0:04 ` [PATCH 4/5] sky2: put PHY in sleep when down Stephen Hemminger
2008-05-15 0:04 ` [PATCH 5/5] sky2: pci power savings Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48354398.9070307@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nickpiggin@yahoo$(echo .)com.au \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox