From: Patrick McHardy <kaber@trash•net>
To: Jarek Poplawski <jarkao2@gmail•com>
Cc: David Miller <davem@davemloft•net>,
Eric Sesterhenn <snakebyte@gmx•de>,
netdev@vger•kernel.org
Subject: Re: [PATCH][NETFILTER]: fix inconsistent lock state in nf_ct_frag6_gather()
Date: Mon, 02 Jun 2008 15:24:02 +0200 [thread overview]
Message-ID: <4843F472.1000306@trash.net> (raw)
In-Reply-To: <20080602124500.GA4463@ff.dom.local>
Jarek Poplawski wrote:
> On Mon, Jun 02, 2008 at 12:43:42PM +0200, Patrick McHardy wrote:
>> Jarek Poplawski wrote:
>>> According to this and another similar lockdep report inet_fragment
>>> locks are taken from nf_ct_frag6_gather() with softirqs enabled, but
>>> these locks are mainly used in softirq context, so disabling BHs is
>>> necessary.
>> Yes, this can happen on the local output path,
>>
>>> David & Patrick,
>>>
>>> It looks like this patch could be applied.
>> Looks mostly fine, but don't we also have to disable BHs for
>> the inet_frag_find() call in nf_ct_frag6_gather()?
>>
>
> Probably I miss something, but I think this patch seems to do it:
> I can see only one such call in nf_ct_frag6_gather() - with
> fq_find()?
Right, I missed that, sorry.
> BTW, it looks like this lockdep warning points at some other possible
> problem: inet_fragment.c uses an SMP "optimization" in
> inet_frag_intern(), probably assuming softirq context; so without such
> BH blocking around inet_frag_find(), there should be at least
> preemption disabled, but I don't know if it's a problem for nf_ct.
Yes, good catch. With your patch things should be fine however.
I've applied your patch and will also push it to -stable.
prev parent reply other threads:[~2008-06-02 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 12:02 Inconsistend lock state in inet_frag_find Eric Sesterhenn
2008-05-30 10:53 ` Jarek Poplawski
2008-05-30 13:18 ` Eric Sesterhenn
2008-05-30 17:10 ` Jarek Poplawski
2008-05-30 21:13 ` Eric Sesterhenn
2008-05-30 21:53 ` [PATCH][NETFILTER]: fix inconsistent lock state in nf_ct_frag6_gather() Jarek Poplawski
2008-06-02 10:43 ` Patrick McHardy
2008-06-02 12:45 ` Jarek Poplawski
2008-06-02 13:24 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4843F472.1000306@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jarkao2@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=snakebyte@gmx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox