Subject: Re: pppoe: Unshare skb before anything else

From: James Chapman <[email-masked]>
Date: Sun, 08 Jun 2008 11:08:59 +0100

Herbert Xu wrote:
> Hi Dave:
> 
> I noticed that my last patch to move the unshare in pppoe missed
> the other spot which did the same thing:
> 
> pppoe: Unshare skb before anything else
> 
> We need to unshare the skb first as otherwise pskb_may_pull may
> write to a shared skb which could be bad.

The same problem exists in the pppol2tp driver. Patch to follow. I'm 
also fixing the copy-to-iovec issue.

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development