From: Jeff Garzik <jgarzik@pobox•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Stephen Hemminger <shemminger@linux-foundation•org>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH] sky2: Hold RTNL while calling dev_close() [2nd try]
Date: Tue, 10 Jun 2008 18:16:42 -0400 [thread overview]
Message-ID: <484EFD4A.3030107@pobox.com> (raw)
In-Reply-To: <20080531155251.GM1743@solarflare.com>
Ben Hutchings wrote:
> dev_close() must be called holding the RTNL. Compile-tested only.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare•com>
> ---
> drivers/net/sky2.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
> index f226bca..b9bdf88 100644
> --- a/drivers/net/sky2.c
> +++ b/drivers/net/sky2.c
> @@ -4395,7 +4395,9 @@ static int sky2_resume(struct pci_dev *pdev)
> if (err) {
> printk(KERN_ERR PFX "%s: could not up: %d\n",
> dev->name, err);
> + rtnl_lock();
> dev_close(dev);
> + rtnl_unlock();
> goto out;
> }
stephen acked this? I don't see that in my notes...
next prev parent reply other threads:[~2008-06-10 22:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 18:26 [PATCH 0/4] dev_open() and dev_close() require RTNL Ben Hutchings
2008-05-06 18:34 ` [PATCH 1/4] Added ASSERT_RTNL() to dev_open() and dev_close() Ben Hutchings
2008-05-08 9:53 ` David Miller
2008-05-06 18:36 ` [PATCH 2/4] qla3xxx: Hold RTNL while calling dev_close() Ben Hutchings
2008-05-08 9:53 ` David Miller
2008-06-27 5:32 ` Jeff Garzik
2008-05-06 18:39 ` [PATCH 3/4] sky2: " Ben Hutchings
2008-05-06 20:26 ` Stephen Hemminger
2008-05-06 23:17 ` Stephen Hemminger
2008-05-06 23:59 ` Ben Hutchings
2008-05-31 15:52 ` [PATCH] sky2: Hold RTNL while calling dev_close() [2nd try] Ben Hutchings
2008-06-10 22:16 ` Jeff Garzik [this message]
2008-06-10 22:25 ` Stephen Hemminger
2008-06-10 22:40 ` Jeff Garzik
2008-05-06 18:41 ` [PATCH 4/4] Hold RTNL while calling dev_close() Ben Hutchings
2008-05-08 9:54 ` David Miller
2008-06-27 5:32 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484EFD4A.3030107@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox