Subject: Re: [PATCH 05/26] IPVS: Use new address family specific debugging macros.

From: Patrick McHardy <[email-masked]>
Date: Wed, 11 Jun 2008 19:14:53 +0200

Julius R. Volz wrote:
> Change debug output to use address family specific debugging macros where
> appropriate.
>
> -		IP_VS_ERR("request control DEL for uncontrolled: "
> -			  "%d.%d.%d.%d:%d to %d.%d.%d.%d:%d\n",
> -			  NIPQUAD(cp->caddr),ntohs(cp->cport),
> -			  NIPQUAD(cp->vaddr),ntohs(cp->vport));
> +		IP_VS_ERR_V4(cp->af, "request control DEL for uncontrolled: "
> +			     "%d.%d.%d.%d:%d to %d.%d.%d.%d:%d\n",
> +			     NIPQUAD(cp->caddr.v4),ntohs(cp->cport),
> +			     NIPQUAD(cp->vaddr.v4),ntohs(cp->vport));
> +
> +		IP_VS_ERR_V6(cp->af, "request control DEL for uncontrolled: "
> +			     NIP6_FMT ":%d to " NIP6_FMT ":%d\n",
> +			     NIP6(cp->caddr.v6),ntohs(cp->cport),
> +			     NIP6(cp->vaddr.v6),ntohs(cp->vport));
> +
>   

This would look at lot cleaner if you'd use a debugging macro that
can take both families.