Subject: Re: [PATCH] firmware: convert e100 driver to request_firmware()

From: Jeff Garzik <[email-masked]>
Date: Sun, 15 Jun 2008 13:50:47 -0400

David Woodhouse wrote:
> From: Jaswinder Singh <[email-masked]>
> 
> Thanks to David Woodhouse for help.
> 
> Signed-off-by: Jaswinder Singh <[email-masked]>
> Signed-off-by: David Woodhouse <[email-masked]>
> ---
> We have assumed that in the no-µcode case, there's no actual _reason_
> for the cb_nop command which e100_setup_ucode() was sending; it's just
> that there was no way for it to simply refrain from sending a command,
> since it returns void.
> 
> Abusing the skb parameter for e100_exec_cb() isn't massively pretty, but
> it should work. We could always add a struct firmware * into 'struct
> nic' if people really object.
> 
> And finally, we've assumed that aborting is the correct thing to do when
> the µcode can't be loaded. Should we instead just complain and move on? 
> 
>  drivers/net/Kconfig                |    8 +
>  drivers/net/e100.c                 |  283 +++++++++++-------------------------
>  firmware/Makefile                  |    2 +
>  firmware/WHENCE                    |   12 ++
>  firmware/e100/d101m_ucode.bin.ihex |   38 +++++
>  firmware/e100/d101s_ucode.bin.ihex |   38 +++++
>  firmware/e100/d102e_ucode.bin.ihex |   38 +++++
>  7 files changed, 222 insertions(+), 197 deletions(-)
>  create mode 100644 firmware/e100/d101m_ucode.bin.ihex
>  create mode 100644 firmware/e100/d101s_ucode.bin.ihex
>  create mode 100644 firmware/e100/d102e_ucode.bin.ihex

NAK - firmware should not be stored in a separate directory from the 
driver to which it is intimately tied.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
E1000-devel mailing list
[email-masked]
https://lists.sourceforge.net/lists/listinfo/e1000-devel