Subject: Re: [PATCH] firmware: convert e100 driver to request_firmware()

From: Jeff Garzik <[email-masked]>
Date: Sun, 15 Jun 2008 14:44:08 -0400

Jaswinder Singh wrote:
> Hello Jeff,
> 
> On 6/15/08, Jeff Garzik <[email-masked]> wrote:
>> David Woodhouse wrote:
>>> From: Jaswinder Singh <[email-masked]>
>>>
>>>  drivers/net/Kconfig                |    8 +
>>>  drivers/net/e100.c                 |  283
>>> +++++++++++-------------------------
>>>  firmware/Makefile                  |    2 +
>>>  firmware/WHENCE                    |   12 ++
>>>  firmware/e100/d101m_ucode.bin.ihex |   38 +++++
>>>  firmware/e100/d101s_ucode.bin.ihex |   38 +++++
>>>  firmware/e100/d102e_ucode.bin.ihex |   38 +++++
>>>  7 files changed, 222 insertions(+), 197 deletions(-)
>>>  create mode 100644 firmware/e100/d101m_ucode.bin.ihex
>>>  create mode 100644 firmware/e100/d101s_ucode.bin.ihex
>>>  create mode 100644 firmware/e100/d102e_ucode.bin.ihex
>> NAK - firmware should not be stored in a separate directory from the
>> driver to which it is intimately tied.
>>
> 
> driver source code will goto drivers directory and firmware will goto
> firmware directory.
> Please let us know, how can we keep them in same directory.

How?  It is simply a matter of changing the Makefile rules.

Each driver is _intimately_ tied to its firmware, so it only increases 
headaches by separating two pieces of a single, cohesive whole.

	Jeff

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php