From: Jeff Garzik <jeff@garzik•org>
To: Ben Dooks <ben-linux@fluff•org>
Cc: netdev@vger•kernel.org, cooloney@kernel•org
Subject: Re: DM9000: Remove blackfin as special case.
Date: Tue, 17 Jun 2008 23:02:02 -0400 [thread overview]
Message-ID: <48587AAA.8080005@garzik.org> (raw)
In-Reply-To: <20080615233648.597885961@fluff.org.uk>
Ben Dooks wrote:
> The first part of remove the DEFAULT_TRIGGER should
> be relatively easy to fixup in whatever blackfin archs
> still use this.
>
> The otherbits, I would recommend the relevant blackfin
> IO headers should deal with defining the six functions to
> the relevant blackfin implementation.
>
> I would have sent this directly to the blackfin list, but
> it is marked as subscribers only.
>
> CC: Bryan Wu <cooloney@kernel•org>
> Signed-off-by: Ben Dooks <ben-linux@fluff•org>
>
> Index: linux-2.6.26-rc6-quilt1/drivers/net/dm9000.c
> ===================================================================
> --- linux-2.6.26-rc6-quilt1.orig/drivers/net/dm9000.c 2008-06-16 00:31:57.000000000 +0100
> +++ linux-2.6.26-rc6-quilt1/drivers/net/dm9000.c 2008-06-16 00:32:17.000000000 +0100
> @@ -47,18 +47,6 @@
> #define CARDNAME "dm9000"
> #define DRV_VERSION "1.31"
>
> -#ifdef CONFIG_BLACKFIN
> -#define readsb insb
> -#define readsw insw
> -#define readsl insl
> -#define writesb outsb
> -#define writesw outsw
> -#define writesl outsl
> -#define DEFAULT_TRIGGER IRQF_TRIGGER_HIGH
> -#else
> -#define DEFAULT_TRIGGER (0)
> -#endif
> -
> /*
> * Transmit timeout, default 5 seconds.
> */
> @@ -1012,10 +1000,8 @@ dm9000_open(struct net_device *dev)
> /* If there is no IRQ type specified, default to something that
> * may work, and tell the user that this is a problem */
>
> - if (irqflags == IRQF_TRIGGER_NONE) {
> + if (irqflags == IRQF_TRIGGER_NONE)
> dev_warn(db->dev, "WARNING: no IRQ resource flags set.\n");
> - irqflags = DEFAULT_TRIGGER;
Is this for 2.6.26 or 2.6.27?
And please CC me on net driver patches, thanks...
Jeff
next prev parent reply other threads:[~2008-06-18 3:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 23:36 DM9000: Remove blackfin as special case Ben Dooks
2008-06-16 3:28 ` Bryan Wu
2008-06-18 3:02 ` Jeff Garzik [this message]
2008-06-18 8:28 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48587AAA.8080005@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=ben-linux@fluff$(echo .)org \
--cc=cooloney@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox