From: Patrick McHardy <kaber@trash•net>
To: Wang Chen <wangchen@cn•fujitsu.com>
Cc: "David S. Miller" <davem@davemloft•net>,
Jeff Garzik <jgarzik@pobox•com>, NETDEV <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 7/8] macvlan: Check return of dev_set_allmulti
Date: Tue, 24 Jun 2008 13:38:52 +0200 [thread overview]
Message-ID: <4860DCCC.1040806@trash.net> (raw)
In-Reply-To: <485BC7E6.20308@cn.fujitsu.com>
Wang Chen wrote:
> Patrick McHardy said the following on 2008-6-20 17:45:
>> Please change this to use gotos for rollback on error.
>>
>
> allmulti might overflow.
> Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
> dev_set_promiscuity/allmulti return error number if overflow happened.
>
> Here, we check the positive increment for allmulti to get error return.
>
> Signed-off-by: Wang Chen <wangchen@cn•fujitsu.com>
Acked-by: Patrick McHardy <kaber@trash•net>
prev parent reply other threads:[~2008-06-24 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 0:55 [PATCH net-next 7/8] macvlan: Check return of dev_set_allmulti Wang Chen
2008-06-20 9:45 ` Patrick McHardy
2008-06-20 15:08 ` Wang Chen
2008-06-24 11:38 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4860DCCC.1040806@trash.net \
--to=kaber@trash$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wangchen@cn$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox