From: Or Gerlitz <ogerlitz@voltaire•com>
To: eli@dev•mellanox.co.il
Cc: netdev@vger•kernel.org, Roland Dreier <rdreier@cisco•com>,
Vladimir Sokolovsky <vlad@mellanox•co.il>,
OpenFabrics General <general@lists•openfabrics.org>,
Jan-Bernd Themann <THEMANN@de•ibm.com>
Subject: Re: [ofa-general] [PATCH] net/inet_lro: remove setting skb->ip_summed when not LRO-able
Date: Wed, 25 Jun 2008 16:01:18 +0300 [thread overview]
Message-ID: <4862419E.5040307@voltaire.com> (raw)
In-Reply-To: <1214397005.23583.60.camel@mtls03>
Eli Cohen wrote:
> We already have this comment:
> u32 ip_summed; /* Set in non generated SKBs in page mode */
>
> I think we should use have it something like that:
> /*
> * Set for generated SKBs in that are not added to
> * the frag list in fragmented mode
> */
> u32 ip_summed;
>
> What do you think?
>
yes, this could be a little more clear.
Or
prev parent reply other threads:[~2008-06-25 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1214318386.23583.37.camel@mtls03>
2008-06-25 9:26 ` [ofa-general] [PATCH] net/inet_lro: remove setting skb->ip_summed when not LRO-able Or Gerlitz
2008-06-25 11:28 ` Jan-Bernd Themann
2008-06-25 11:47 ` Or Gerlitz
2008-06-25 12:10 ` Jan-Bernd Themann
2008-06-25 12:15 ` Jan-Bernd Themann
2008-06-25 12:30 ` Eli Cohen
2008-06-25 13:01 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4862419E.5040307@voltaire.com \
--to=ogerlitz@voltaire$(echo .)com \
--cc=THEMANN@de$(echo .)ibm.com \
--cc=eli@dev$(echo .)mellanox.co.il \
--cc=general@lists$(echo .)openfabrics.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdreier@cisco$(echo .)com \
--cc=vlad@mellanox$(echo .)co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox