Subject: Re: v2 [PATCH net-next 5/7] ipv4: Check return of dev_set_allmulti

From: Patrick McHardy <[email-masked]>
Date: Tue, 01 Jul 2008 11:57:13 +0200

Wang Chen wrote:
> Patrick McHardy said the following on 2008-7-1 17:40:
>> Wang Chen wrote:
>>> -    dev_set_allmulti(dev, +1);
>>> +    err = dev_set_allmulti(dev, 1);
>>> +    if (err)
>>> +        return err;
>> Missing error handling for VIFF_REGISTER and VIFF_TUNNEL case.
>>
> 
> will do.

Thanks. I didn't check the other patches (except those
I ACKed). Please also verify wether they all do error
handling properly.

> seems 
>>      if ((in_dev = __in_dev_get_rtnl(dev)) == NULL)
> should do error handling too.

Doesn't seem necessary, it doesn't take a reference or has
any other sideeffects.