Subject: Re: [PATCH] sctp: remove unnecessary byteshifting, calculate crc in big-endian

From: Vlad Yasevich <[email-masked]>
Date: Thu, 10 Jul 2008 08:43:28 -0400

Harvey Harrison wrote:
> On Wed, 2008-07-09 at 16:59 -0400, Vlad Yasevich wrote:
>> Harvey Harrison wrote:
>>> -	__u32 crc32 = 0;
>>> +	__be32 crc32 = cpu_to_be32(0);
>> Does this actually do anything?
>>
>> Otherwise, good clean-up. Thanks
>>
> 
> Keeps sparse happy.

Wouldn't just a (__force __be32)0 do the same thing and
avoid useless byte swapping on little endian?

-vald

> Harvey