Subject: Re: [PATCH 20/31] netns ct: NOTRACK in netns

From: Patrick McHardy <[email-masked]>
Date: Mon, 21 Jul 2008 19:08:43 +0200

Jan Engelhardt wrote:
> On Monday 2008-07-21 18:50, Alexey Dobriyan wrote:
> 
>> +++ b/net/netfilter/xt_state.c
>> @@ -30,7 +31,7 @@ state_mt(const struct sk_buff *skb, const struct net_device *in,
>> 	enum ip_conntrack_info ctinfo;
>> 	unsigned int statebit;
>>
>> -	if (nf_ct_is_untracked(skb))
>> +	if (nf_ct_is_untracked(dev_net(in ? in : out), skb))
> 
> Does this even do the right thing? Given the forward path, where
> both in!=NULL and out!=NULL, why should it specifically be 'in'
> that is selected?

It doesn't matter, the namespace during forwaring is always
equal for the input and output devices.