Subject: Re: [PATCH 2/2] myri10ge: use ioremap_wc

From: Brice Goglin <[email-masked]>
Date: Sun, 10 Aug 2008 13:59:31 +0200

Martin Michlmayr wrote:
> * Brice Goglin <[email-masked]> [2008-07-21 10:26]:
>   
>> Switch to ioremap_wc(). We keep the MTRR code since ioremap_wc()
>> will use UC_MINUS when falling back to uncachable, and thus let
>> the MTRR WC take precedence.
>>     
>
> This change leads to a compilation failure on (at least) arm:
>
>   CC [M]  drivers/net/myri10ge/myri10ge.o
> drivers/net/myri10ge/myri10ge.c: In function ‘myri10ge_probe’:
> drivers/net/myri10ge/myri10ge.c:3725: error: implicit declaration of function ‘ioremap_wc’
> drivers/net/myri10ge/myri10ge.c:3725: warning: assignment makes pointer from integer without a cast
> make[3]: *** [drivers/net/myri10ge/myri10ge.o] Error 1
>   

Isn't arm's asm/io.h supposed to get
#ifndef ARCH_HAS_IOREMAP_WC
#define ioremap_wc ioremap_nocache
#endif
from asm-generic/iomap.h since ARCH_HAS_IOREMAP_WC isn't defined on arm ?

Brice