Subject: Re: [PATCH] nf_conntrack_sip: fix by making helper pointers thread-local

From: Patrick McHardy <[email-masked]>
Date: Thu, 21 Aug 2008 13:28:56 +0200

[email-masked] wrote:
> Patrick, do I read correctly that ->help hook can run concurrently with itself?
> 
> If yes, apply this patch to fix potential crashes and all sorts of
> nasties.
> 
> 
> 
> [PATCH] nf_conntrack_sip: de-static helper pointers
> 
> Helper's ->help hook can run concurrently with itself, so iterating over
> SIP helpers with static pointer won't work reliably.

Crap. Good catch, thanks a lot. Applied and I'll push it to -stable.