Subject: Re: [NET-NEXT PATCH] e1000: remove unused Kconfig option for disabling packet split

From: Jeff Garzik <[email-masked]>
Date: Wed, 03 Sep 2008 09:59:08 -0400

Jeff Kirsher wrote:
> From: Jesse Brandeburg <[email-masked]>
> 
> Since the e1000/e1000e split, no hardware supported by e1000
> supports packet split, just remove the Kconfig option and associated
> code from arch/* and the driver.
> 
> Signed-off-by: Jesse Brandeburg <[email-masked]>
> Signed-off-by: Jeff Kirsher <[email-masked]>
> ---
> 
>  arch/arm/configs/iop13xx_defconfig              |    1 
>  arch/arm/configs/iop32x_defconfig               |    1 
>  arch/arm/configs/iop33x_defconfig               |    1 
>  arch/arm/configs/ixp23xx_defconfig              |    1 
>  arch/arm/configs/kirkwood_defconfig             |    1 
>  arch/ia64/configs/generic_defconfig             |    1 
>  arch/ia64/configs/gensparse_defconfig           |    1 
>  arch/ia64/configs/tiger_defconfig               |    1 
>  arch/ia64/configs/zx1_defconfig                 |    1 
>  arch/mips/configs/mtx1_defconfig                |    1 
>  arch/parisc/configs/a500_defconfig              |    1 
>  arch/parisc/configs/c3000_defconfig             |    1 
>  arch/powerpc/configs/83xx/mpc832x_rdb_defconfig |    1 
>  arch/powerpc/configs/85xx/mpc8560_ads_defconfig |    1 
>  arch/powerpc/configs/85xx/mpc85xx_cds_defconfig |    1 
>  arch/powerpc/configs/85xx/tqm8548_defconfig     |    1 
>  arch/powerpc/configs/cell_defconfig             |    1 
>  arch/powerpc/configs/g5_defconfig               |    1 
>  arch/powerpc/configs/iseries_defconfig          |    1 
>  arch/powerpc/configs/maple_defconfig            |    1 
>  arch/powerpc/configs/pasemi_defconfig           |    1 
>  arch/powerpc/configs/ppc64_defconfig            |    1 
>  arch/powerpc/configs/ppc6xx_defconfig           |    1 
>  arch/powerpc/configs/prpmc2800_defconfig        |    1 
>  arch/powerpc/configs/pseries_defconfig          |    1 
>  arch/sh/configs/r7780mp_defconfig               |    1 
>  arch/sparc64/defconfig                          |    1 
>  arch/x86/configs/i386_defconfig                 |    1 
>  arch/x86/configs/x86_64_defconfig               |    1 
>  drivers/net/Kconfig                             |    9 
>  drivers/net/e1000/e1000.h                       |   17 -
>  drivers/net/e1000/e1000_main.c                  |  416 -----------------------
>  32 files changed, 9 insertions(+), 462 deletions(-)

ACK, except for the defconfig changes.  arch maintainers usually prefer 
to do that themselves.

We'd be continually patch defconfig files, if we did so every time it 
was likely one would be updated by a Kconfig patch.