Subject: Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference

From: Jeff Garzik <[email-masked]>
Date: Wed, 03 Sep 2008 10:12:34 -0400

Krzysztof Halasa wrote:
> Adrian Bunk <[email-masked]> writes:
> 
>> --- a/drivers/net/wan/hdlc_x25.c
>> +++ b/drivers/net/wan/hdlc_x25.c
>> @@ -163,10 +163,8 @@ static void x25_close(struct net_device *dev)
>>  
>>  static int x25_rx(struct sk_buff *skb)
>>  {
>> -	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) {
>> -		skb->dev->stats.rx_dropped++;
>> +	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
>>  		return NET_RX_DROP;
>> -	}
>>  
> 
> Right, thanks... though I will update the stats anyway.

In terms of patches... what does this mean?  Does this mean you are 
taking Adrian's patch, and updating it?  Sending a follow-up patch? 
Ack'ing Adrian's patch?

I don't want to hold this back due to lack of stat update...