Subject: Re: [PATCH 21/25] netns ct: per-netns event cache

From: Patrick McHardy <[email-masked]>
Date: Fri, 05 Sep 2008 13:34:39 +0200

Alexey Dobriyan wrote:
> On Thu, Sep 04, 2008 at 06:58:38PM +0200, Patrick McHardy wrote:
>> [email-masked] wrote:
>>>  static inline void
>>> -nf_conntrack_event_cache(enum ip_conntrack_events event,
>>> +nf_conntrack_event_cache(struct net *net, enum ip_conntrack_events event,
>>>  			 const struct sk_buff *skb)
>>>  {
>> Passing the conntrack instead of the struct net and the skb
>> would probably keep the callers cleaner.
> 
> Dunno, passing netns explicitly like saying conntrack event happened in
> netns A, which is reasonable. OTOH, s/skb/ct/ is indeed nicer.
> 
> I'll change it as you suggest and see what happens.
> 
> BTW, I asked earlier if untracked conntracks are ever supposed to drop into
> event cache. If they're, trimming nf_conntrack_untracked is out of question.

No, they are skipped by the only event handler, ctnetlink.