Subject: Re: [PATCH 0/4] atlx: add atl2 support

From: Chris Snook <[email-masked]>
Date: Sun, 14 Sep 2008 23:26:53 -0400

Jeff Garzik wrote:
> On Sun, Sep 14, 2008 at 06:14:10PM -0400, Chris Snook wrote:
>> Jeff Garzik wrote:
>>> Chris Snook wrote:
>>>> This patchset adds support for atl2 hardware to the atlx codebase.  It is
>>>> functionally very similar to the out-of-tree 2.0.4 version that many  
>>>> distros
>>>> have been shipping for a few months, though it adds a fix from 
>>>> Atheros to fix
>>>> the problem of device resets under heavy bidirectional load.
>>>>
>>>> The code needs a lot of janitorial work, and there's a lot of  
>>>> low-hanging fruit
>>>> for merging similar atl1 code into the shared atlx code, but I think  
>>>> that work
>>>> will go much faster once this is in-tree.  The driver is known to 
>>>> work well for
>>>> laptop and desktop use.  The only major bugs are device 
>>>> initialization problems
>>>> that manifest themselves immediately and obviously (the NIC doesn't  
>>>> work) with
>>>> certain motherboards.
>>>>
>>>> Please consider this for the 2.6.28 merge window.
>>>>
>>>> -- Chris
>>>>
>>>>  drivers/net/Kconfig       |   17
>>>>  drivers/net/Makefile      |    1
>>>>  drivers/net/atlx/Makefile |    1
>>>>  drivers/net/atlx/atl2.c   | 3101  
>>>> ++++++++++++++++++++++++++++++++++++++++++++++
>>>>  drivers/net/atlx/atl2.h   |  482 +++++++
>>>>  include/linux/pci_ids.h   |    1
>>>>  6 files changed, 3600 insertions(+), 3 deletions(-)
>>> Send as one big patch, please?
>>>
>>>
>> It's too big for vger as one patch.  There's a lot of code that can be 
>> whittled down, but this driver has been delayed for months already 
>> waiting for that to be finished.  Would you prefer a gzipped One Big 
>> Patch?
> 
> _I_ need it in standard patch format, as one big patch.  No MIME
> encoding, no gzip, no URLs, just a patch like any other.
> 
> 	Jeff

See Jay's post, in single-patch form, with some additional cosmetic cleanups and 
my signoff.

-- Chris