Subject: Re: [PATCH 1/1] qlge: New Qlogic 10Gb Ethernet Driver single patch

From: Jeff Garzik <[email-masked]>
Date: Thu, 18 Sep 2008 12:10:01 -0400

Ron Mercer wrote:
>>>From c041fd2a648cc2685b21cb7e722ba9fb05be114e Mon Sep 17 00:00:00 2001
> From: Ron Mercer <[email-masked]>
> Date: Tue, 16 Sep 2008 12:17:52 -0700
> Subject: [PATCH 1/1] qlge: New Qlogic 10Gb Ethernet Driver.
> 
> 
> Signed-off-by: Ron Mercer <[email-masked]>
> ---
>  Documentation/networking/LICENSE.qlge |   46 +
>  MAINTAINERS                           |    7 +
>  drivers/net/Kconfig                   |    9 +
>  drivers/net/Makefile                  |    1 +
>  drivers/net/qlge/Makefile             |    7 +
>  drivers/net/qlge/qlge.h               | 1593 +++++++++++++
>  drivers/net/qlge/qlge_dbg.c           |  858 +++++++
>  drivers/net/qlge/qlge_ethtool.c       |  415 ++++
>  drivers/net/qlge/qlge_main.c          | 3954 +++++++++++++++++++++++++++++++++
>  drivers/net/qlge/qlge_mpi.c           |  150 ++
>  10 files changed, 7040 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/networking/LICENSE.qlge
>  create mode 100644 drivers/net/qlge/Makefile
>  create mode 100644 drivers/net/qlge/qlge.h
>  create mode 100644 drivers/net/qlge/qlge_dbg.c
>  create mode 100644 drivers/net/qlge/qlge_ethtool.c
>  create mode 100644 drivers/net/qlge/qlge_main.c
>  create mode 100644 drivers/net/qlge/qlge_mpi.c

applied, after fixing pci_dma_mapping_error() build breakage:  you only 
used one argument, when calling pci_dma_mapping_error().  I'm guessing 
that (a) you did not build test this on multiple platforms, both 32-bit 
and 64-bit, or (b) you are building against an older version of the kernel?

Either way, no big deal, I fixed it.  But that's something to watch for 
next time.  Your patches should always successfully build, ideally.