Subject: Re: [PATCH] e1000e: release hw semaphore after successfully writing EEPROM

From: "Kok, Auke" <[email-masked]>
Date: Mon, 29 Sep 2008 15:48:41 -0700

looks totally valid to me indeed!

Reviewed-by: Auke Kok <[email-masked]>

Auke

Arthur Jones wrote:
> Since e1000e has been existance in linux-2.6, we've
> never released the hardware semaphore after a successful
> write to the SPI EEPROM.  I guess we don't write to
> SPI EEPROM much -- but those few of us that do appreciate
> it when we can later read from the EEPROM without having
> to reboot.
> 
> Found-by: Nick Van Fossen <[email-masked]>
> Signed-off-by: Arthur Jones <[email-masked]>
> ---
>  drivers/net/e1000e/lib.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/e1000e/lib.c b/drivers/net/e1000e/lib.c
> index f1f4e9d..6492107 100644
> --- a/drivers/net/e1000e/lib.c
> +++ b/drivers/net/e1000e/lib.c
> @@ -2012,6 +2012,7 @@ s32 e1000e_write_nvm_spi(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)
>  	}
>  
>  	msleep(10);
> +	nvm->ops.release_nvm(hw);
>  	return 0;
>  }
>