public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash•net>
To: Ingo Molnar <mingo@elte•hu>
Cc: Alexey Dobriyan <adobriyan@gmail•com>,
	shemminger@linux-foundation•org, netdev@vger•kernel.org,
	containers@lists•linux-foundation.org, kaber@trash•et,
	"David S. Miller" <davem@davemloft•net>,
	linux-kernel@vger•kernel.org,
	Jan Engelhardt <jengelh@computergmbh•de>,
	Netfilter Development Mailinglist
	<netfilter-devel@vger•kernel.org>
Subject: Re: [bug, -git] ERROR: "ebt_unregister_table"	[net/bridge/netfilter/ebtable_nat.ko] undefined
Date: Tue, 14 Oct 2008 13:00:09 +0200	[thread overview]
Message-ID: <48F47BB9.9090902@trash.net> (raw)
In-Reply-To: <20081014103005.GA19420@elte.hu>

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

Ingo Molnar wrote:
> i think you misunderstood my report. This is about latest upstream -git 
> being broken:
> 
> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> i posted to this thread because i wanted to find a relevant context. 
> (but probably is not)
> 
> Anyway, i started a new thread for this.
> 
> the dependencies there look pretty complex so i did not find a quick fix 
> - but i can test patches.

This appears to be caused by Jan's Kconfig changes to use menuconfig,
which lost a dependency on BRIDGE:

-menu "Bridge: Netfilter Configuration"
-       depends on BRIDGE && BRIDGE_NETFILTER
-
-config BRIDGE_NF_EBTABLES
+menuconfig BRIDGE_NF_EBTABLES
         tristate "Ethernet Bridge tables (ebtables) support"
         select NETFILTER_XTABLES
         help
           ebtables is a general, extensible frame/packet identification
           framework. Say 'Y' or 'M' here if you want to do Ethernet
           filtering/NAT/brouting on the Ethernet bridge.

Does this patch fix it?

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 417 bytes --]

diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
index 366d3e9..ba6f73e 100644
--- a/net/bridge/netfilter/Kconfig
+++ b/net/bridge/netfilter/Kconfig
@@ -4,6 +4,7 @@
 
 menuconfig BRIDGE_NF_EBTABLES
 	tristate "Ethernet Bridge tables (ebtables) support"
+	depends on BRIDGE && BRIDGE_NETFILTER
 	select NETFILTER_XTABLES
 	help
 	  ebtables is a general, extensible frame/packet identification

  reply	other threads:[~2008-10-14 11:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 22:20 [PATCH 1/6] netns brnetfilter: per-netns ebtables adobriyan
2008-08-21 22:41 ` adobriyan
2008-10-13  7:03 ` Ingo Molnar
2008-10-13  7:09   ` Ingo Molnar
2008-10-13  7:35     ` Alexey Dobriyan
2008-10-14 10:30       ` [bug, -git] ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_nat.ko] undefined Ingo Molnar
2008-10-14 11:00         ` Patrick McHardy [this message]
2008-10-14 11:48           ` Ingo Molnar
2008-10-14 11:51             ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F47BB9.9090902@trash.net \
    --to=kaber@trash$(echo .)net \
    --cc=adobriyan@gmail$(echo .)com \
    --cc=containers@lists$(echo .)linux-foundation.org \
    --cc=davem@davemloft$(echo .)net \
    --cc=jengelh@computergmbh$(echo .)de \
    --cc=kaber@trash$(echo .)et \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=mingo@elte$(echo .)hu \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=shemminger@linux-foundation$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox