From: Chris Snook <csnook@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: afleming@gmail•com, afleming@freescale•com, netdev@vger•kernel.org
Subject: Re: [PATCH] Change S390 anti-dependency to CONFIG_GENERIC_HARDIRQS dependency
Date: Tue, 14 Oct 2008 20:07:55 -0400 [thread overview]
Message-ID: <48F5345B.6060108@redhat.com> (raw)
In-Reply-To: <20081014.165211.53009170.davem@davemloft.net>
David Miller wrote:
> From: Chris Snook <csnook@redhat•com>
> Date: Tue, 14 Oct 2008 19:43:05 -0400
>
>> David Miller wrote:
>>> From: "Andy Fleming" <afleming@gmail•com>
>>> Date: Tue, 14 Oct 2008 18:21:44 -0500
>>>
>>>> Argh. From what I could see, we have request_irq, free_irq,
>>>> disable_irq, enable_irq, and disable_irq_nosync. For the PHYLIB, it
>>>> shouldn't be difficult to modify things so that it doesn't compile in
>>>> interrupt support if the system doesn't support them. Shouldn't, that
>>>> is, if there's some config option that tells me whether those
>>>> functions exist.
>>> I think this whole situation with s390 is rediculious.
>>> If s390 is weird and lacks these fundamental things, that's fine.
>>> What isn't fine is how we're handling this.
>>> No code should care or even be aware of this.
>>> S390 should simply provide a set of dummy DMA and interrupt interface
>>> stubs that always fail and return an error value.
>>> Then we can get rid of this S390 Kconfig stuff which has been spewed
>>> all over the place.
>> "depends on PCI" has always worked for me. Any reason we can't use that here?
>
> That's every worse.
>
> What in the world does PCI have to do with the attribute we are
> trying to depend upon here?
>
> No, it's just stupid. Add nop do-nothing stub functions for the
> APIs an architecture doesn't support, then we need none of this.
But then it will be much more of a pain to exclude the vast swath of
irrelevant code in the kernel tree from your builds on these exotic
architectures. Have you ever built a kernel on s390? It's not exactly
the architecture's strong suit, and cross-compilers have their own
problems. I don't care what it is, but we should have *some* mechanism
for automatically excluding every PCI device driver in existence from
our builds of s390 and any other similarly unusual architecture.
-- Chris
next prev parent reply other threads:[~2008-10-15 0:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 22:28 [PATCH] Change S390 anti-dependency to CONFIG_GENERIC_HARDIRQS dependency Andy Fleming
2008-10-14 22:44 ` David Miller
2008-10-14 23:21 ` Andy Fleming
2008-10-14 23:33 ` David Miller
2008-10-14 23:43 ` Chris Snook
2008-10-14 23:52 ` David Miller
2008-10-15 0:07 ` Chris Snook [this message]
2008-10-15 5:16 ` David Miller
2008-10-15 16:48 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F5345B.6060108@redhat.com \
--to=csnook@redhat$(echo .)com \
--cc=afleming@freescale$(echo .)com \
--cc=afleming@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox