Subject: Re: [PATCH 3/6] pkt_sched: sch_generic: Add generic qdisc->ops->peek() implementation.

From: Patrick McHardy <[email-masked]>
Date: Thu, 16 Oct 2008 14:19:37 +0200

Jarek Poplawski wrote:
> pkt_sched: sch_generic: Add generic qdisc->ops->peek() implementation.
> 

> +	if (qops->peek == NULL)
> +		qops->peek = noop_qdisc_ops.peek;
>  	if (qops->dequeue == NULL)
>  		qops->dequeue = noop_qdisc_ops.dequeue;

->dequeue and ->peek are somewhat tied together, so I think we should
only use the noop variants if both are unset. Whether this should be
checked here of before merging new qdiscs is a different question of
course :)