Subject: Re: [PATCH] sky2: skb recycling

From: Terry <[email-masked]>
Date: Tue, 21 Oct 2008 16:49:47 +0800

Robert Olsson wrote:
> Eric Dumazet writes:
>  > Stephen Hemminger a écrit :
>  > > Add support for recycling tx buffers into receive buffers.
>  > > This is experimental at this point.
>  > > 
>  > 
>  > I really like this skb recycling
>
> Hi,
>
> Well the best and cleanest thing would be if the "global" recycler slab/slub 
> was fast enough. Historically it seems like every time the link speed increases 
> (now to 10g) alloc/kfree pops up on the profiles but that challenge has sofar
> been handled by slab/slub folks. Maybe we should consult them first...
>
> Also there was some discussions to have packet objects in slab.
>  
> Cheers.
> 					--ro
>
>
>   
Hi 
    yeah. In the forwarding scenario , skb recycling should boost the 
performance by avoiding slowpath slub alloc/free .But if  using 
multiqueue hardware and assigning proper  cpu affinities  could  make it 
always in the fastpath of slub  alloc/free, which is faster?

Terry