From: Jeff Garzik <jgarzik@pobox•com>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: Francois Romieu <romieu@fr•zoreil.com>, netdev@vger•kernel.org
Subject: Re: [PATCH] 8139x: reduce message severity on driver overlap
Date: Wed, 22 Oct 2008 07:01:42 -0400 [thread overview]
Message-ID: <48FF0816.6000303@pobox.com> (raw)
In-Reply-To: <20081021180427.6d4668d7@extreme>
Stephen Hemminger wrote:
> The 8139 drivers are a source of error messages that confuse users.
> Since this device can not be disambiguated by normal PCI device id's two drivers
> match the same info. But the module utilities seem to correctly handle this overlap,
> they try one driver, then if that doesn't load try the other. Therefore there is
> no need for a message to be logged with error level severity, just using info
> level instead. Can't be completely silent because user might have configure one driver
> and forgot the other one.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
>
> --- a/drivers/net/8139cp.c 2008-10-21 17:51:23.000000000 -0700
> +++ b/drivers/net/8139cp.c 2008-10-21 17:58:00.000000000 -0700
> @@ -1836,10 +1836,9 @@ static int cp_init_one (struct pci_dev *
>
> if (pdev->vendor == PCI_VENDOR_ID_REALTEK &&
> pdev->device == PCI_DEVICE_ID_REALTEK_8139 && pdev->revision < 0x20) {
> - dev_err(&pdev->dev,
> - "This (id %04x:%04x rev %02x) is not an 8139C+ compatible chip\n",
> + dev_info(&pdev->dev,
> + "This (id %04x:%04x rev %02x) is not an 8139C+ compatible chip, use 8139too\n",
> pdev->vendor, pdev->device, pdev->revision);
> - dev_err(&pdev->dev, "Try the \"8139too\" driver instead.\n");
> return -ENODEV;
> }
>
> --- a/drivers/net/8139too.c 2008-10-21 17:51:27.000000000 -0700
> +++ b/drivers/net/8139too.c 2008-10-21 17:58:01.000000000 -0700
> @@ -946,10 +946,9 @@ static int __devinit rtl8139_init_one (s
> if (pdev->vendor == PCI_VENDOR_ID_REALTEK &&
> pdev->device == PCI_DEVICE_ID_REALTEK_8139 && pdev->revision >= 0x20) {
> dev_info(&pdev->dev,
> - "This (id %04x:%04x rev %02x) is an enhanced 8139C+ chip\n",
> + "This (id %04x:%04x rev %02x) is an enhanced 8139C+ chip, use 8139cp\n",
> pdev->vendor, pdev->device, pdev->revision);
> - dev_info(&pdev->dev,
> - "Use the \"8139cp\" driver for improved performance and stability.\n");
> + return -ENODEV;
> }
>
> if (pdev->vendor == PCI_VENDOR_ID_REALTEK &&
applied
prev parent reply other threads:[~2008-10-22 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 1:04 [PATCH] 8139x: reduce message severity on driver overlap Stephen Hemminger
2008-10-22 11:01 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF0816.6000303@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox