From: Rick Jones <rick.jones2@hp•com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel•com>
Cc: "e1000-devel@lists•sourceforge.net"
<e1000-devel@lists•sourceforge.net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel•com>,
"Allan, Bruce W" <bruce.w.allan@intel•com>,
"jeffery.t.kirsher@intel•com" <jeffery.t.kirsher@intel•com>,
Stephen Hemminger <shemminger@vyatta•com>
Subject: Re: [RFC 1/2] igb: statistic optimization
Date: Wed, 22 Oct 2008 10:37:44 -0700 [thread overview]
Message-ID: <48FF64E8.4050907@hp.com> (raw)
In-Reply-To: <Pine.WNT.4.63.0810211224440.2736@jbrandeb-desk.amr.corp.intel.com>
> I don't think you want to put this in the code that can be called directly
> from IOCTL from userspace. This function can take a lot of cycles and
> some silly applications like gkrellm call it quite frequently. The
> update_stats function will be called as part of the watchdog anyway, and
> you already got the interesting stats for realtime with the tx and rx
> bytes/packets.
On the flip side aren't there "out of phase" issues with pulling stats
based on a timer vs something like a netstat -i 1 command?
rick jones
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
next prev parent reply other threads:[~2008-10-22 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 19:09 [RFC 1/2] igb: statistic optimization Stephen Hemminger
2008-10-21 19:30 ` Brandeburg, Jesse
2008-10-21 19:31 ` Waskiewicz Jr, Peter P
2008-10-22 17:37 ` Rick Jones [this message]
2008-10-22 17:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FF64E8.4050907@hp.com \
--to=rick.jones2@hp$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=jeffery.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox