Subject: Re: [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk

From: Jeff Garzik <[email-masked]>
Date: Fri, 24 Oct 2008 22:22:54 -0400

Jeff Kirsher wrote:
> On Fri, Oct 24, 2008 at 6:13 PM, Jeff Kirsher
> <[email-masked]> wrote:
>> From: Bruce Allan <[email-masked]>
>>
>> The write-protection method being in the driver probe routine is called
>> late in the boot sequence, and not at all if the driver is never loaded.
>> By making it a PCI quirk the NVM is protected much earlier whether or not
>> the driver is loaded.  The write-protection quirk can be disabled with a
>> new kernel parameter in the unlikely event the NVM needs to be modified.
>>
>> Signed-off-by: Bruce Allan <[email-masked]>
>> Signed-off-by: Jeff Kirsher <[email-masked]>
>> ---
>>
>>  Documentation/kernel-parameters.txt |    4 +
>>  drivers/net/Makefile                |    1
>>  drivers/net/e1000e/Makefile         |    1
>>  drivers/net/e1000e/e1000.h          |    1
>>  drivers/net/e1000e/ethtool.c        |    6 +
>>  drivers/net/e1000e/ich8lan.c        |   93 +++-----------------
>>  drivers/net/e1000e/ich8lan.h        |   68 +++++++++++++++
>>  drivers/net/e1000e/netdev.c         |    4 -
>>  drivers/net/e1000e/param.c          |   30 ------
>>  drivers/net/e1000e/quirks.c         |  162 +++++++++++++++++++++++++++++++++++
>>  10 files changed, 256 insertions(+), 114 deletions(-)
>>  create mode 100644 drivers/net/e1000e/ich8lan.h
>>  create mode 100644 drivers/net/e1000e/quirks.c
>>
>>
> 
> This PCI quirk is put in ./drivers/net/e1000e in order to share
> defines and structs found in the driver source, and is only applicable
> to ICHx GbE LOMs supported by that driver anyway.

Seems to be it is not difficult to put it into drivers/pci/quirks.c, 
where it belongs.

	Jeff