Subject: Re: [PATCH] phylib: add mdio-gpio bus driver (v2)

From: Paulius Zaleckas <[email-masked]>
Date: Tue, 28 Oct 2008 09:37:51 +0200

Mike Frysinger wrote:
> On Mon, Oct 27, 2008 at 06:53, Paulius Zaleckas wrote:
>> +       new_bus->irq = kmalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL);
> 
> oh, and this should be kcalloc()

Why? kcalloc() fills allocated memory with zeros and in this case it has
to be filled with -1... this is done by further for() routine. I don't
see the point to fill it with zeros before...

> -mike