Subject: Re: [PATCH] ixgbe: Fix usage of netif_*_all_queues() with netif_carrier_{off|on}()

From: Jeff Garzik <[email-masked]>
Date: Tue, 11 Nov 2008 03:33:45 -0500

Jeff Kirsher wrote:
> From: PJ Waskiewicz <[email-masked]>
> 
> netif_carrier_off() is sufficient to stop Tx into the driver.  Stopping the Tx
> queues is redundant and unnecessary.  By the same token, netif_carrier_on()
> will be sufficient to re-enable Tx, so waking the queues is unnecessary.

Is this a fix as the subject says (2.6.28), or an optimization as the 
description implies (2.6.29)?

AFAICS from a quick glance, things are not actually _broken_, are they?

	Jeff