Subject: Re: [PATCH net-next]netdevice: 82596: Convert netdev->priv to netdev_priv

From: Wang Chen <[email-masked]>
Date: Mon, 17 Nov 2008 14:58:35 +0800

David Miller said the following on 2008-11-17 14:36:
> From: Wang Chen <[email-masked]>
> Date: Mon, 17 Nov 2008 14:04:13 +0800
> 
>> -#ifdef __mc68000__
>> -	cache_push(virt_to_phys((void *)(dev->mem_start)), 4096);
>> -	cache_clear(virt_to_phys((void *)(dev->mem_start)), 4096);
>> -	kernel_set_cachemode((void *)(dev->mem_start), 4096, IOMAP_NOCACHE_SER);
>> -#endif
> 
> Do you have any idea what this code is doing that you are removing?
> 
> It's changing the cache mode of the memory behind ->mem_start because
> this "lp" struct is directly accessed by the hardware, and without
> these operations the CPU and the device won't see consistent
> values in the structure.
> 
> Therefore your change breaks the driver.
> 

Yes. I was wrong.
Will send a patch again.
Thank you for stopping my fool code.