Subject: Re: [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter

From: Oliver Hartkopp <[email-masked]>
Date: Mon, 01 Dec 2008 19:42:31 +0100

Sam Ravnborg wrote:
> On Mon, Dec 01, 2008 at 05:15:42PM +0100, Oliver Hartkopp wrote:
>   
>>
>> Thanks to Kurt Van Dijck for pointing at this issue and for the review.
>>
>> Signed-Off-by: Oliver Hartkopp <[email-masked]>
>> Acked-by: Kurt Van Dijck <[email-masked]>
>>     
>
> If Kurt tested this patch then he should
> be credited with a "Tested-by:" tag.
>
> I recall he did but I deleted the thread from my can mailbox.
>
> 	Sam
>   
Hi Sam,

i did some testing and posted the results of a first patch that went 
into the final direction.

In

https://lists.berlios.de/pipermail/socketcan-core/2008-December/002117.html

Kurt gave a "Reviewed-by:" and in a later mail in

https://lists.berlios.de/pipermail/socketcan-core/2008-December/002119.html

he wrote "my Acked-by: still stands" for the final patch.

So i choosed "Acked-by:".

As Kurt went that deep into the code that he pointed me to the right 
line and presented a first idea for a patch, an 'Acked-by:' for 
confirming the final patch looked like an appropriate credit to me.

Regards,
Oliver