From: James Chapman <jchapman@katalix•com>
To: Wang Chen <wangchen@cn•fujitsu.com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] ppp: fix segfaults introduced by netdev_priv changes
Date: Thu, 18 Dec 2008 10:24:43 +0000 [thread overview]
Message-ID: <494A24EB.8020307@katalix.com> (raw)
In-Reply-To: <4949B240.7060102@cn.fujitsu.com>
Wang Chen wrote:
> I have no comment on these changes, but
> there is a path that calls only ppp_destroy_interface() no
> ppp_shutdown_interface().
> it's:
> ppp_unregister_channel
> --->ppp_disconnect_channel()
> ---> ppp_destroy_interface()
Isn't ppp_shutdown_interface() always called first? If not, then we need
to unregister_netdev() before the free_netdev() call in
ppp_destroy_interface(). The original code didn't cover that case.
>> /*
>> @@ -2616,7 +2614,7 @@ ppp_connect_channel(struct channel *pch, int unit)
>> if (pch->file.hdrlen > ppp->file.hdrlen)
>> ppp->file.hdrlen = pch->file.hdrlen;
>> hdrlen = pch->file.hdrlen + 2; /* for protocol bytes */
>> - if (ppp->dev && hdrlen > ppp->dev->hard_header_len)
>> + if (hdrlen > ppp->dev->hard_header_len)
>> ppp->dev->hard_header_len = hdrlen;
>> list_add_tail(&pch->clist, &ppp->channels);
>> ++ppp->n_channels;
>
> I don't understand this change.
> Do you mean that in this place, ppp->dev will never be NULL?
After my change, yes. See the comment in the patch preamble.
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2008-12-18 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 22:02 [PATCH] ppp: fix segfaults introduced by netdev_priv changes James Chapman
2008-12-18 2:15 ` Wang Chen
2008-12-18 10:24 ` James Chapman [this message]
2008-12-18 3:20 ` David Miller
2008-12-18 10:28 ` James Chapman
2008-12-19 3:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494A24EB.8020307@katalix.com \
--to=jchapman@katalix$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wangchen@cn$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox