From: Santwona.Behera@Sun•COM
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, jeff@garzik•org,
gkernel-commit@lists•sourceforge.net,
Matheos Worku <Matheos.Worku@Sun•COM>,
Mehdi Bonyadi <Mehdi.Bonyadi@Sun•COM>
Subject: Re: [PATCH 2/3] Add support for RX packet classification in a network device
Date: Mon, 22 Dec 2008 16:36:31 -0800 [thread overview]
Message-ID: <4950328F.9020409@Sun.COM> (raw)
In-Reply-To: <1229991408.3077.19.camel@achroite>
>>
>> 1. I change AH_ESP_Vx_FLOW defines to AH_Vx_FLOW defines and add 2 new
>> defines for ESP_Vx_FLOW at the end, with values 0x9 and 0xa.
>
> If AH_ESP_Vx_FLOW has only ever been implemented as AH-only then perhaps
> this is reasonable.
>
>> 2. I keep the AH_ESP_Vx_FLOW defines as is (but this will be dead code
>> as it will not be used) and add 2 new AH_Vx_FLOW defines and 2 new
>> ESP_Vx_FLOW defines at the end with values 0x9, 0xa, 0xb, 0xc.
>
> This is safest.
OK, I will re-implement it this way then.
>
> Also you are probably right to remove RXH_DEV_PORT as that appears to be
> an niu quirk that shouldn't be exposed.
That was the reasoning behind removing RXH_DEV_PORT.
rgds,
--santwona
prev parent reply other threads:[~2008-12-23 0:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 18:45 [PATCH 2/3] Add support for RX packet classification in a network device Santwona.Behera
2008-12-22 19:27 ` Ben Hutchings
2008-12-22 23:04 ` Santwona.Behera
2008-12-23 0:16 ` Ben Hutchings
2008-12-23 0:36 ` Santwona.Behera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4950328F.9020409@Sun.COM \
--to=santwona.behera@sun$(echo .)com \
--cc=Matheos.Worku@Sun$(echo .)COM \
--cc=Mehdi.Bonyadi@Sun$(echo .)COM \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gkernel-commit@lists$(echo .)sourceforge.net \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox