From: Vladislav Bolkhovitin <vst@vlnb•net>
To: Evgeniy Polyakov <zbr@ioremap•net>
Cc: Herbert Xu <herbert@gondor•apana.org.au>,
Jeremy Fitzhardinge <jeremy@goop•org>,
linux-scsi@vger•kernel.org,
James Bottomley <James.Bottomley@HansenPartnership•com>,
Andrew Morton <akpm@linux-foundation•org>,
FUJITA Tomonori <fujita.tomonori@lab•ntt.co.jp>,
Mike Christie <michaelc@cs•wisc.edu>,
Jeff Garzik <jeff@garzik•org>,
Boaz Harrosh <bharrosh@panasas•com>,
Linus Torvalds <torvalds@linux-foundation•org>,
linux-kernel@vger•kernel.org, scst-devel@lists•sourceforge.net,
Bart Van Assche <bart.vanassche@gmail•com>,
"Nicholas A. Bellinger" <nab@linux-iscsi•org>,
netdev@vger•kernel.org, Rusty Russell <rusty@rustcorp•com.au>,
David Miller <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>
Subject: Re: [PATCH][RFC 23/23]: Support for zero-copy TCP transmit of user space data
Date: Wed, 24 Dec 2008 17:37:51 +0300 [thread overview]
Message-ID: <4952493F.10508@vlnb.net> (raw)
In-Reply-To: <20081223213817.GB16883@ioremap.net>
Evgeniy Polyakov, on 12/24/2008 12:38 AM wrote:
> On Tue, Dec 23, 2008 at 10:16:25PM +0300, Vladislav Bolkhovitin (vst@vlnb•net) wrote:
>> Actually, there's another way, which seems to be a lot simpler. Alexey
>> Kuznetsov privately suggested it to me.
>>
>> In skb_shared_info new pointer transaction_token would be added, which
>> would point on:
>>
>> struct sk_transaction_token
>> {
>> atomic_t io_count;
>> struct sk_transaction_token *next;
>> unsigned long token;
>> unsigned long private;
>> void (*finish_callback)(struct
>> sk_transaction_token *);
>> };
>>
>> When skb is translated, transaction_token inherited. If 2 skb are merged
>> (the same places where I put net_get_page's in my patch), the *older*
>> token is inherited. This is the main point of this idea.
>>
>> Before starting new asynchronous send a client would open a new token.
>> Everything sent then would receive that token. Finish_callback() would
>> be called and the corresponding token freed, when io_count == 0 *AND*
>> all previous tokens closed.
>>
>> This idea seems to be simpler, than even what Rusty implemented. Correct
>> me, if I wrong. But, unfortunately, in the near future I will have no
>> time to develop it.. :-(
>
> Yes, it is simpler and cleaner, but it requires additional allocation.
> This is additional (and quite noticeble) overhead.
Not necessary requires. For instance, in iscsi-scst sk_transaction_token
can (and should) be part of iSCSI cmd structure, so no additional
allocations would be needed.
Thanks,
Vlad
next prev parent reply other threads:[~2008-12-24 14:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 18:26 [PATCH][RFC 0/23] New SCSI target framework (SCST) and 4 target drivers Vladislav Bolkhovitin
2008-12-10 19:01 ` [PATCH][RFC 21/23]: iSCSI target driver Vladislav Bolkhovitin
2008-12-11 22:55 ` Nicholas A. Bellinger
2008-12-11 22:59 ` Nicholas A. Bellinger
2008-12-12 19:26 ` Vladislav Bolkhovitin
2008-12-10 19:02 ` [PATCH][RFC 22/23]: Documentation for iSCSI-SCST Vladislav Bolkhovitin
2008-12-10 19:04 ` [PATCH][RFC 23/23]: Support for zero-copy TCP transmit of user space data Vladislav Bolkhovitin
2008-12-10 21:45 ` Evgeniy Polyakov
2008-12-11 18:16 ` Vladislav Bolkhovitin
2008-12-11 19:12 ` James Bottomley
2008-12-12 19:25 ` Vladislav Bolkhovitin
2008-12-12 19:37 ` James Bottomley
2008-12-15 17:58 ` Vladislav Bolkhovitin
2008-12-15 23:18 ` Christoph Hellwig
2008-12-16 18:57 ` Vladislav Bolkhovitin
2008-12-18 18:35 ` [RFC]: " Vladislav Bolkhovitin
2008-12-18 18:43 ` David M. Lloyd
2008-12-19 17:37 ` Vladislav Bolkhovitin
2008-12-19 19:07 ` Jens Axboe
2008-12-19 19:17 ` Vladislav Bolkhovitin
2008-12-19 19:27 ` Jens Axboe
2008-12-19 21:58 ` Evgeniy Polyakov
2008-12-23 19:11 ` Vladislav Bolkhovitin
2008-12-19 11:27 ` Andi Kleen
2008-12-19 17:38 ` Vladislav Bolkhovitin
2008-12-19 18:00 ` Andi Kleen
2008-12-19 17:57 ` Vladislav Bolkhovitin
2008-12-16 16:00 ` [PATCH][RFC 23/23]: " Bart Van Assche
2008-12-16 17:41 ` Evgeniy Polyakov
2008-12-19 20:21 ` Jeremy Fitzhardinge
2008-12-19 22:04 ` Evgeniy Polyakov
2008-12-19 22:21 ` Jeremy Fitzhardinge
2008-12-19 22:33 ` Evgeniy Polyakov
2008-12-20 1:56 ` Jeremy Fitzhardinge
2008-12-20 2:02 ` Herbert Xu
2008-12-20 6:14 ` Jeremy Fitzhardinge
2008-12-20 6:51 ` Herbert Xu
2008-12-20 7:43 ` Jeremy Fitzhardinge
2008-12-20 8:10 ` Herbert Xu
2008-12-20 10:32 ` Evgeniy Polyakov
2008-12-20 19:39 ` Jeremy Fitzhardinge
2008-12-22 0:43 ` Rusty Russell
2008-12-23 19:14 ` Vladislav Bolkhovitin
2008-12-23 19:16 ` Vladislav Bolkhovitin
2008-12-23 21:38 ` Evgeniy Polyakov
2008-12-24 14:37 ` Vladislav Bolkhovitin [this message]
2008-12-24 14:44 ` Evgeniy Polyakov
2008-12-24 17:46 ` Vladislav Bolkhovitin
2008-12-24 18:08 ` Evgeniy Polyakov
2008-12-30 17:37 ` Vladislav Bolkhovitin
2008-12-30 21:35 ` Evgeniy Polyakov
2008-12-23 19:13 ` Vladislav Bolkhovitin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4952493F.10508@vlnb.net \
--to=vst@vlnb$(echo .)net \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bart.vanassche@gmail$(echo .)com \
--cc=bharrosh@panasas$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fujita.tomonori@lab$(echo .)ntt.co.jp \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jeff@garzik$(echo .)org \
--cc=jeremy@goop$(echo .)org \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=michaelc@cs$(echo .)wisc.edu \
--cc=nab@linux-iscsi$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=scst-devel@lists$(echo .)sourceforge.net \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=zbr@ioremap$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox