From: Jeff Garzik <jgarzik@pobox•com>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: Ben Hutchings <bhutchings@solarflare•com>,
Rick Jones <rick.jones2@hp•com>,
davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH] Make possible speeds known to ethtool
Date: Thu, 08 Jan 2009 22:20:43 -0500 [thread overview]
Message-ID: <4966C28B.6060304@pobox.com> (raw)
In-Reply-To: <20090109025244.GA11336@gondor.apana.org.au>
Herbert Xu wrote:
> On Thu, Jan 08, 2009 at 03:12:01AM +0000, Jeff Garzik wrote:
>> The next release of ethtool is coming in about 4 weeks, and we can
>> definitely get something like this in there.
>
> Jeff, any chance you can stick this patch in there to add the GRO
> toggle?
>
> ethtool: Add GRO toggle
>
> This patch adds the -k toggles to query and set GRO on a device.
>
> Signed-off-by: Herbert Xu <herbert@gondor•apana.org.au>
>
> diff --git a/ethtool-copy.h b/ethtool-copy.h
> index eadba25..3ca4e2c 100644
> --- a/ethtool-copy.h
> +++ b/ethtool-copy.h
> @@ -336,6 +336,8 @@ struct ethtool_rxnfc {
>
> #define ETHTOOL_GRXFH 0x00000029 /* Get RX flow hash configuration */
> #define ETHTOOL_SRXFH 0x0000002a /* Set RX flow hash configuration */
> +#define ETHTOOL_GGRO 0x0000002b /* Get GRO enable (ethtool_value) */
> +#define ETHTOOL_SGRO 0x0000002c /* Set GRO enable (ethtool_value) */
Ugh... is it too late to change this interface?
The person who added this should have used the new flags interface, and
added ETH_FLAG_GRO right next to the pre-existing ETH_FLAG_LRO.
It is incorrect to add new ioctls just to toggle a boolean value.
Jeff
next prev parent reply other threads:[~2009-01-09 3:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 2:03 [PATCH] Make possible speeds known to ethtool Rick Jones
2009-01-08 3:14 ` Ben Hutchings
2009-01-08 3:12 ` Jeff Garzik
2009-01-08 19:11 ` Rick Jones
2009-01-08 19:25 ` Ben Hutchings
2009-01-08 19:50 ` Rick Jones
2009-01-09 13:16 ` [PATCH] ethtool: Support arbitrary speeds Ben Hutchings
2009-01-09 17:55 ` Rick Jones
2009-01-09 18:24 ` Ben Hutchings
2009-01-09 18:40 ` Rick Jones
2009-03-06 11:20 ` Jeff Garzik
2009-03-06 12:27 ` Jeff Garzik
2009-01-09 2:52 ` [PATCH] Make possible speeds known to ethtool Herbert Xu
2009-01-09 3:20 ` Jeff Garzik [this message]
2009-03-06 11:19 ` Jeff Garzik
2009-03-06 13:52 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2009-01-09 3:48 Herbert Xu
2009-01-09 3:58 ` Jeff Garzik
2009-01-09 4:19 Herbert Xu
2009-01-09 5:00 ` David Miller
2009-01-09 5:05 ` Jeff Garzik
2009-01-09 5:03 ` Jeff Garzik
2009-01-09 5:15 ` Herbert Xu
2009-01-09 5:30 ` Jeff Garzik
2009-01-09 5:35 ` Herbert Xu
2009-01-09 6:28 ` Jeff Garzik
2009-01-09 6:30 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4966C28B.6060304@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rick.jones2@hp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox