Subject: Re: [Devel] Re: [RFC][PATCH] IP address restricting cgroup subsystem

From: Li Zefan <[email-masked]>
Date: Sat, 10 Jan 2009 12:50:41 +0800

Paul Menage wrote:
> On Wed, Jan 7, 2009 at 1:33 AM, Li Zefan <[email-masked]> wrote:
>>> Yes, I like that. Will update the patch. I assume that I must check
>>> list_empty(&cgroup->children)?
>> Yes.
>>
>>> Should I use cgroup_lock()/cgroup_unlock()
>> Yes.
> 
> For checking the "children" list, you can just lock
> ipaddr_subsys.hierarchy_mutex.
> 

Unfortunately hierarchy_mutex can't be used here, since hierarchy_mutex
doesn't protect subsys's create() method, and the create() will access
parent cgroup's data.