From: Greg Ungerer <gerg@snapgear•com>
To: Sascha Hauer <s.hauer@pengutronix•de>
Cc: netdev@vger•kernel.org, Sebastian Siewior <bigeasy@linutronix•de>
Subject: Re: [RFC] FEC patches
Date: Fri, 16 Jan 2009 10:10:41 +1000 [thread overview]
Message-ID: <496FD081.6060803@snapgear.com> (raw)
In-Reply-To: <20090115102413.GT11228@pengutronix.de>
Hi Sascha,
Sascha Hauer wrote:
> On Thu, Jan 15, 2009 at 02:06:55PM +1000, Greg Ungerer wrote:
>> Hi Sacha,
>>
>> Sascha Hauer wrote:
>>> The following patches apply to the FEC driver (drivers/net/fec.c). While
>>> found on several Freescale/Motorola chips, this driver is currently only
>>> used for Coldfire. These patches add support for the ARM based i.MX27
>>> SoC.
>>>
>>> I'm almost sure I break the driver for some (all?) Coldfire guys, but I
>>> do not have any Coldfire based board to test the patches on.
>> I can test patches on most ColdFire boards.
>>
>>
>>> The first 4 patches should be ok as is, comments?
>> Only the one that I commented on with FEC_FLASHMAC.
>> Otherwise the first 4 apply and work for ColdFire.
>>
>>
>>> The other patches are somewhat work in progress, but they show which
>>> changes I need for my hardware.
>> Currently the change to use dma_alloc_coherent breaks ColdFire.
>> I need to debug that and see why that is the case.
>>
>> Otherwise they look ok to me.
>>
>>
>>> The driver could use quite some cleanup patches for coding style, turn
>>> it into a platform device driver and add exit functions. I'm sure I
>> Yes, it does badly need this. I have been meaning to extract
>> the ColdFire platform specifics for some time. That would improve
>> it quite a bit.
>>
>
> My plan is to put the current static initialization code into some kind
> of #ifdef FEC_LEGACY and use a proper platform device driver otherwise.
> This would leave the code in place for now and it could be ported over
> to platform devices per platform. Is this ok for you?
Yeah, that is ok by me.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear•com
SnapGear, a McAfee Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2009-01-16 0:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 16:09 [RFC] FEC patches Sascha Hauer
2009-01-14 16:09 ` [PATCH] fec: remove unused #else branches Sascha Hauer
2009-01-14 16:09 ` [PATCH] fec: remove empty functions Sascha Hauer
2009-01-14 16:09 ` [PATCH] fec: use linux/*.h instead of asm/*.h Sascha Hauer
2009-01-14 16:09 ` [PATCH] fec: do not use memcpy on physical addresses Sascha Hauer
2009-01-14 16:09 ` [PATCH] fec: use dma_alloc_coherent for descriptor ring Sascha Hauer
2009-01-14 16:09 ` [PATCH] fec: Add mx2 support (WIP) Sascha Hauer
2009-01-15 7:22 ` Greg Ungerer
2009-01-15 10:15 ` Sascha Hauer
2009-01-15 5:20 ` [PATCH] fec: use dma_alloc_coherent for descriptor ring Greg Ungerer
2009-01-15 3:55 ` [PATCH] fec: do not use memcpy on physical addresses Greg Ungerer
2009-01-15 3:55 ` [PATCH] fec: use linux/*.h instead of asm/*.h Greg Ungerer
2009-01-15 3:54 ` [PATCH] fec: remove empty functions Greg Ungerer
2009-01-15 3:43 ` [PATCH] fec: remove unused #else branches Greg Ungerer
2009-01-15 10:17 ` Sascha Hauer
2009-01-15 4:06 ` [RFC] FEC patches Greg Ungerer
2009-01-15 10:24 ` Sascha Hauer
2009-01-16 0:10 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496FD081.6060803@snapgear.com \
--to=gerg@snapgear$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=s.hauer@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox