Subject: Re: cxgb3: Replace LRO with GRO

From: Divy Le Ray <[email-masked]>
Date: Fri, 16 Jan 2009 00:06:45 -0800

Herbert Xu wrote:
> Divy Le Ray <[email-masked]> wrote:
>> Your patch looks fine. Early testing provides the same perfs
>> seen with LRO.
>>
>> I resubmit the original patch with 2 changes:
>> - cxgb3_set_flags() removal did not apply.
>>  commit 47fd23fe8efeea3af4593a8424419df48724eb25 had updated the routine.
>> - replace the NETIF_F_LRO features flag with NETIF_F_GRO
> 
> Thanks for the update Divy! It looks good to me.

Hi Herbert,

The perfs are not actually as good as with LRO.
With a slow server, 1 netperf stream gets on average:
without the patch, lro off: 3.8Gbs
without the patch, lro on: 6.1Gbs
with the patch, GRO on: 4.8Gbs.

I'll look into it.

Cheers,
Divy