Subject: Re: [PATCH] net: A little dev_valid_name() improvement

From: Michael Tokarev <[email-masked]>
Date: Sun, 18 Jan 2009 23:28:46 +0300

Matvejchikov Ilya wrote:
> This patch removes redundant complexity when checking the
> network device name to be valid.

And also disallows any name starting with a dot, while
previously it was allowed/valid.

I don't think this patch is good.

/mjt

> -	if (*name == '\0')
> +	if (*name == '\0' || *name == '.')
>  		return 0;
> -	if (!strcmp(name, ".") || !strcmp(name, ".."))
> -		return 0;