From: Badalian Vyacheslav <slavon@bigtelecom•ru>
To: Jarek Poplawski <jarkao2@gmail•com>
Cc: David Miller <davem@davemloft•net>,
a.p.zijlstra@chello•nl, denys@visp•net.lb,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
tglx@linutronix•de
Subject: Re: [PATCH] Re: deadlocks if use htb
Date: Mon, 19 Jan 2009 10:42:29 +0300 [thread overview]
Message-ID: <49742EE5.9090502@bigtelecom.ru> (raw)
In-Reply-To: <20090119065715.GA4197@ff.dom.local>
Tested 2 days (weekend is stress days for this bug, because its have
many traffic) at 3 servers. Fly normal. For completed test need up to 7
days, but i think (imho) this patch not break any functional and may
safely added to stable. 100% help for me patch # 2+3.
> On Sun, Jan 18, 2009 at 09:46:04PM -0800, David Miller wrote:
>
>> From: Jarek Poplawski <jarkao2@gmail•com>
>> Date: Thu, 15 Jan 2009 06:53:22 +0000
>>
>>
>>> (resend testing patch #4 - for 2.6.27 or 2.6.28)
>>>
>> Jarek, if you deem that this is in fact what we should
>> submit for -stable please give me a submission with
>> a suitable commit message and signoffs, and I will queue
>> it up for -stable.
>>
>
> It looks like this should be needed, but I think it's better to wait
> 2 or 3 days for "Tested-by" from Denys and/or maybe Vyacheslav yet.
> (I hoped they would rather test some hrtimers patch, but it looks like
> Peter was busy.)
>
> Thanks,
> Jarek P.
> -----------------> (needed only for -stables: 2.6.28 and older)
>
> pkt_sched: sch_htb: Fix deadlock in hrtimers triggered by HTB
>
> Most probably there is a (still unproven) race in hrtimers (before
> 2.6.29 kernels), which causes a corruption of hrtimers rbtree. This
> patch doesn't fix it, but should let HTB avoid triggering the bug.
>
> Reported-by: Denys Fedoryschenko <denys@visp•net.lb>
> Reported-by: Badalian Vyacheslav <slavon@bigtelecom•ru>
> Reported-by: Chris Caputo <ccaputo@alt•net>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail•com>
> ---
>
> diff -Nurp a2.6.27.7/net/sched/sch_htb.c b2.6.27.7/net/sched/sch_htb.c
> --- a2.6.27.7/net/sched/sch_htb.c 2008-12-11 08:16:16.000000000 +0000
> +++ b2.6.27.7/net/sched/sch_htb.c 2008-12-15 10:44:32.000000000 +0000
> @@ -924,6 +924,7 @@ static struct sk_buff *htb_dequeue(struc
> }
> }
> sch->qstats.overlimits++;
> + qdisc_watchdog_cancel(&q->watchdog);
> qdisc_watchdog_schedule(&q->watchdog, next_event);
> fin:
> return skb;
>
>
next prev parent reply other threads:[~2009-01-19 7:42 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 5:44 deadlocks if use htb Badalian Vyacheslav
2008-10-10 7:56 ` Jarek Poplawski
2008-10-10 8:46 ` Badalian Vyacheslav
2008-10-10 8:52 ` Badalian Vyacheslav
2008-10-10 9:04 ` Jarek Poplawski
2008-10-10 9:51 ` Jarek Poplawski
2008-10-16 8:28 ` Badalian Vyacheslav
2008-10-16 8:40 ` Jarek Poplawski
2008-10-22 6:06 ` Badalian Vyacheslav
2008-10-22 7:02 ` Jarek Poplawski
2008-12-10 15:14 ` Badalian Vyacheslav
2008-12-11 8:46 ` Jarek Poplawski
2008-12-15 11:13 ` Jarek Poplawski
2008-12-16 7:37 ` Badalian Vyacheslav
2008-12-18 6:43 ` Badalian Vyacheslav
2008-12-18 8:17 ` Jarek Poplawski
2008-12-18 11:23 ` Badalian Vyacheslav
2008-12-18 11:37 ` Jarek Poplawski
2009-01-14 2:43 ` Chris Caputo
2009-01-14 6:39 ` Jarek Poplawski
2009-01-14 12:17 ` Denys Fedoryschenko
2009-01-14 12:36 ` Jarek Poplawski
2009-01-14 12:41 ` Denys Fedoryschenko
2009-01-14 12:50 ` Peter Zijlstra
2009-01-14 13:04 ` Jarek Poplawski
2009-01-14 13:05 ` Denys Fedoryschenko
2009-01-14 13:12 ` Jarek Poplawski
2009-01-14 13:15 ` Peter Zijlstra
2009-01-14 13:19 ` Denys Fedoryschenko
2009-01-14 13:26 ` Jarek Poplawski
2009-01-14 13:32 ` Peter Zijlstra
2009-01-14 13:57 ` Jarek Poplawski
2009-01-14 14:13 ` Jarek Poplawski
2009-01-14 14:28 ` Peter Zijlstra
2009-01-14 14:39 ` Jarek Poplawski
2009-01-15 9:01 ` Jarek Poplawski
2009-01-15 10:46 ` Peter Zijlstra
2009-01-15 10:54 ` Jarek Poplawski
2009-01-14 18:02 ` Chris Caputo
2009-01-15 6:53 ` Jarek Poplawski
2009-01-15 7:12 ` Badalian Vyacheslav
2009-01-15 8:09 ` Jarek Poplawski
2009-01-15 9:01 ` Denys Fedoryschenko
2009-01-15 9:06 ` Jarek Poplawski
2009-01-15 9:40 ` Badalian Vyacheslav
2009-01-15 9:54 ` Jarek Poplawski
2009-01-15 9:57 ` Denys Fedoryschenko
2009-01-15 10:06 ` Jarek Poplawski
2009-01-15 10:10 ` Jarek Poplawski
2009-01-15 10:40 ` Denys Fedoryschenko
2009-01-15 7:26 ` Chris Caputo
2009-01-15 7:54 ` Jarek Poplawski
2009-01-15 9:45 ` Jarek Poplawski
2009-01-15 12:00 ` Chris Caputo
2009-01-15 12:18 ` Jarek Poplawski
2009-01-15 13:53 ` Chris Caputo
2009-01-16 6:51 ` Badalian Vyacheslav
2009-01-19 5:46 ` David Miller
2009-01-19 6:57 ` [PATCH] " Jarek Poplawski
2009-01-19 7:42 ` Badalian Vyacheslav [this message]
2009-01-19 7:57 ` Jarek Poplawski
2009-01-20 1:29 ` David Miller
2008-10-10 12:32 ` Patrick McHardy
2008-10-10 12:34 ` Patrick McHardy
2008-10-10 12:54 ` Badalian Vyacheslav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49742EE5.9090502@bigtelecom.ru \
--to=slavon@bigtelecom$(echo .)ru \
--cc=a.p.zijlstra@chello$(echo .)nl \
--cc=davem@davemloft$(echo .)net \
--cc=denys@visp$(echo .)net.lb \
--cc=jarkao2@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox