From: James Chapman <jchapman@katalix•com>
To: Cyrill Gorcunov <gorcunov@gmail•com>
Cc: davem@davemloft•net, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, devel@openvz•org, xemul@openvz•org,
Michal Ostrowski <mostrows@earthlink•net>,
Cyrill Gorcunov <gorcunov@openvz•org>
Subject: Re: [PATCH 5/5] net: pppoe,pppol2tp - register channels with explicit net
Date: Tue, 20 Jan 2009 21:56:32 +0000 [thread overview]
Message-ID: <49764890.5010403@katalix.com> (raw)
In-Reply-To: <4975dc14.0637560a.7f8e.729c@mx.google.com>
Cyrill Gorcunov wrote:
> In PPPo[E|L2TP] we could explicitly point which net namespace
> we're going to use for channels - make it so.
>
> CC: James Chapman <jchapman@katalix•com>
> CC: Michal Ostrowski <mostrows@earthlink•net>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz•org>
This one's ok by me too for pppol2tp.
Signed-off-by: James Chapman <jchapman@katalix•com>
> ---
> drivers/net/pppoe.c | 2 +-
> drivers/net/pppol2tp.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6.git/drivers/net/pppoe.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/net/pppoe.c
> +++ linux-2.6.git/drivers/net/pppoe.c
> @@ -695,7 +695,7 @@ static int pppoe_connect(struct socket *
> po->chan.private = sk;
> po->chan.ops = &pppoe_chan_ops;
>
> - error = ppp_register_channel(&po->chan);
> + error = ppp_register_net_channel(dev_net(dev), &po->chan);
> if (error)
> goto err_put;
>
> Index: linux-2.6.git/drivers/net/pppol2tp.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/net/pppol2tp.c
> +++ linux-2.6.git/drivers/net/pppol2tp.c
> @@ -1749,7 +1749,7 @@ static int pppol2tp_connect(struct socke
> po->chan.ops = &pppol2tp_chan_ops;
> po->chan.mtu = session->mtu;
>
> - error = ppp_register_channel(&po->chan);
> + error = ppp_register_net_channel(sock_net(sk), &po->chan);
> if (error)
> goto end_put_tun;
>
>
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2009-01-20 21:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090120140510.228815074@gmail.com>
2009-01-20 14:14 ` [PATCH 2/5] net: pppoe - introduce net-namespace functionality Cyrill Gorcunov
2009-01-20 14:14 ` [PATCH 5/5] net: pppoe,pppol2tp - register channels with explicit net Cyrill Gorcunov
2009-01-20 14:14 ` [PATCH 4/5] net: ppp_generic - introduce net-namespace functionality v2 Cyrill Gorcunov
2009-01-20 14:14 ` [PATCH 1/5] net: pppoe - code cleanup and helpers Cyrill Gorcunov
2009-01-20 14:15 ` [PATCH 3/5] net: pppol2tp - introduce net-namespace functionality Cyrill Gorcunov
2009-01-20 14:16 ` [PATCH 1/5] net: pppoe - code cleanup and helpers Cyrill Gorcunov
2009-01-20 14:16 ` [PATCH 5/5] net: pppoe,pppol2tp - register channels with explicit net Cyrill Gorcunov
2009-01-20 14:16 ` [PATCH 3/5] net: pppol2tp - introduce net-namespace functionality Cyrill Gorcunov
2009-01-20 14:17 ` [PATCH 4/5] net: ppp_generic - introduce net-namespace functionality v2 Cyrill Gorcunov
2009-01-20 14:17 ` [PATCH 2/5] net: pppoe - introduce net-namespace functionality Cyrill Gorcunov
[not found] ` <4975dc12.0c07560a.7d35.ffffcc78@mx.google.com>
2009-01-20 21:54 ` [PATCH 3/5] net: pppol2tp " James Chapman
[not found] ` <4975dc14.0637560a.7f8e.729c@mx.google.com>
2009-01-20 21:56 ` James Chapman [this message]
2009-01-20 21:58 ` [PATCH 5/5] net: pppoe,pppol2tp - register channels with explicit net Cyrill Gorcunov
2009-01-21 0:09 ` Divy Le Ray
2009-01-21 0:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49764890.5010403@katalix.com \
--to=jchapman@katalix$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=gorcunov@gmail$(echo .)com \
--cc=gorcunov@openvz$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mostrows@earthlink$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xemul@openvz$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox