From: Mike Christie <michaelc@cs•wisc.edu>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel•com>
Cc: netdev@vger•kernel.org, olaf.kirch@oracle•com, tgraf@suug•ch,
kkeil@suse•de, herbert@gondor•apana.org.au
Subject: Re: [PANIC] lro + iscsi or lro + skb text search causes panic
Date: Thu, 22 Jan 2009 16:49:40 -0600 [thread overview]
Message-ID: <4978F804.3060502@cs.wisc.edu> (raw)
In-Reply-To: <alpine.WNT.2.00.0901221234420.4188@jbrandeb-desk1.amr.corp.intel.com>
Brandeburg, Jesse wrote:
>
> skb_copy_bits is an example of the code flow that does work.
>
> skb_seq_read appears to only be used by iSCSI and the skb text match
> support in tc/netfilter (aka skb_find_text)
>
There is no reason iscsi needs to use skb_seq_read. It used to use
skb_copy_bits. I can convert iscsi to use skb_copy_bits again.
Is it easier to just convert the text search to not use skb_seq_read,
and then just dump those functions?
next prev parent reply other threads:[~2009-01-22 23:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 20:55 [PANIC] lro + iscsi or lro + skb text search causes panic Brandeburg, Jesse
2009-01-22 22:49 ` Mike Christie [this message]
2009-01-23 4:22 ` Mike Christie
2009-01-23 4:29 ` Mike Christie
2009-01-26 5:34 ` David Miller
2009-01-22 23:21 ` Herbert Xu
2009-01-22 23:45 ` Brandeburg, Jesse
2009-01-23 0:04 ` Mike Christie
2009-01-26 5:32 ` David Miller
2009-01-26 22:30 ` Herbert Xu
2009-01-27 1:40 ` Brandeburg, Jesse
2009-01-27 3:01 ` Herbert Xu
2009-01-27 5:52 ` David Miller
2009-01-27 6:12 ` Mike Christie
[not found] ` <46A00B48CC54E4468EF6911F877AC4CA01EF2BC9@blrx3m10.blr.amer.dell.com>
2009-01-28 21:25 ` Herbert Xu
2009-01-30 0:13 ` David Miller
2009-01-26 20:54 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2009-01-28 12:36 Shyam_Iyer
2009-01-28 18:22 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4978F804.3060502@cs.wisc.edu \
--to=michaelc@cs$(echo .)wisc.edu \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=kkeil@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olaf.kirch@oracle$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox