From: Eric Dumazet <dada1@cosmosbay•com>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH 5/5] netfilter: convert x_tables to use RCU
Date: Fri, 30 Jan 2009 08:05:07 +0100 [thread overview]
Message-ID: <4982A6A3.2090304@cosmosbay.com> (raw)
In-Reply-To: <4982A60F.8020005@cosmosbay.com>
Eric Dumazet a écrit :
>
> Hum, I just checked and indeed there is a problem...
>
> #define SUM_COUNTER(s,c) do { (s).bcnt += (c).bcnt; (s).pcnt += (c).pcnt; } while(0)
>
> need to be changed to use
>
> #define SUM_COUNTER(s, c) do { xt_incr_counter(s, (c).cnt, (c).pcnt);} while (0)
>
Oops
#define SUM_COUNTER(s, c) xt_incr_counter(s, (c).bcnt, (c).pcnt)
next prev parent reply other threads:[~2009-01-30 7:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 6:25 [PATCH 0/5] iptables lockless receive (v0.3) Stephen Hemminger
2009-01-29 6:25 ` [PATCH 1/5] netfilter: change elements in x_tables Stephen Hemminger
2009-01-29 6:25 ` [PATCH 2/5] netfilter: remove unneeded initializations Stephen Hemminger
2009-01-29 6:25 ` [PATCH 3/5] ebtables: " Stephen Hemminger
2009-01-29 6:25 ` [PATCH 4/5] netfilter: use sequence number synchronization for counters Stephen Hemminger
2009-01-29 8:47 ` Eric Dumazet
2009-01-29 6:25 ` [PATCH 5/5] netfilter: convert x_tables to use RCU Stephen Hemminger
2009-01-29 23:04 ` Eric Dumazet
2009-01-29 23:16 ` Stephen Hemminger
2009-01-30 6:53 ` Eric Dumazet
2009-01-30 7:02 ` Eric Dumazet
2009-01-30 7:05 ` Eric Dumazet [this message]
2009-01-29 8:07 ` [PATCH 0/5] iptables lockless receive (v0.3) Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4982A6A3.2090304@cosmosbay.com \
--to=dada1@cosmosbay$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox