From: Benjamin ZORES <benjamin.zores@alcatel-lucent•fr>
To: netdev@vger•kernel.org
Subject: Re: [PATCH] Fix infinite retry loop in IP-Config
Date: Fri, 30 Jan 2009 09:25:39 +0100 [thread overview]
Message-ID: <4982B983.6020704@alcatel-lucent.fr> (raw)
In-Reply-To: <20090129.161929.241520668.davem@davemloft.net>
David Miller a écrit :
> From: Benjamin ZORES <benjamin.zores@alcatel-lucent•fr>
> Date: Wed, 28 Jan 2009 13:08:15 +0100
>
>
>> Jarek Poplawski a écrit :
>>
>>> On 28-01-2009 10:07, Benjamin ZORES wrote:
>>>
>>>
>>>> diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
>>>> index 42a0f3d..4911b81 100644
>>>> --- a/net/ipv4/ipconfig.c
>>>> +++ b/net/ipv4/ipconfig.c
>>>> @@ -1268,6 +1268,7 @@ __be32 __init root_nfs_parse_addr(char *name)
>>>> static int __init ip_auto_config(void)
>>>> {
>>>> __be32 addr;
>>>> + int retries = CONF_OPEN_RETRIES;
>>>>
>>>>
>>> Doesn't it need "#ifdef IPCONFIG_DYNAMIC" to prevent a compiler
>>> warning? I guess you could add a "Signed-off-by:" line BTW.
>>>
>>>
>> You're perfectly right about this.
>> Attached an updated version of the patch.
>>
>
> Patch applied, thank you.
Be my guest. Thanks to you.
Ben
prev parent reply other threads:[~2009-01-30 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 9:07 [PATCH] Fix infinite retry loop in IP-Config Benjamin ZORES
2009-01-28 10:52 ` Jarek Poplawski
2009-01-28 12:08 ` Benjamin ZORES
2009-01-29 15:33 ` Benjamin ZORES
2009-01-29 20:39 ` David Miller
2009-01-30 0:19 ` David Miller
2009-01-30 8:25 ` Benjamin ZORES [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4982B983.6020704@alcatel-lucent.fr \
--to=benjamin.zores@alcatel-lucent$(echo .)fr \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox